Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make series findable via search #360

Closed
LukasKalbertodt opened this issue Mar 14, 2022 · 2 comments · Fixed by #1144
Closed

Make series findable via search #360

LukasKalbertodt opened this issue Mar 14, 2022 · 2 comments · Fixed by #1144
Labels
area:frontend Everything frontend related area:search Related to Tobira's search kind:new-feature A new feature

Comments

@LukasKalbertodt
Copy link
Member

LukasKalbertodt commented Mar 14, 2022 •
edited by lkiesow
Loading

Series should appear in search results when searching for their title
@LukasKalbertodt LukasKalbertodt added area:frontend Everything frontend related kind:new-feature A new feature area:search Related to Tobira's search labels Mar 14, 2022
@LukasKalbertodt LukasKalbertodt moved this to Todo in Tobira Mar 14, 2022
@LukasKalbertodt LukasKalbertodt mentioned this issue Mar 27, 2022
Merged
@LukasKalbertodt LukasKalbertodt mentioned this issue Jan 19, 2023
Closed
@oas777
Copy link
Collaborator

oas777 commented Jun 8, 2023

Isn't that the case already? Cf. https://tobira.opencast.org/~search?q=Latsis.

@LukasKalbertodt
Copy link
Member Author

What you are seeing there are pages. This is of course confusing as many pages have the same name as a series and only the series is shown on those pages. So for those, it is indeed not a problem. But imagine a series that doesn't have a dedicated page in the page structure: that cannot be found via search currently.

Of course, adding this feature (making series findable), we should take care that we won't show the series AND the page for that series, as that would be confusing for users.

@owi92 owi92 mentioned this issue Mar 18, 2024
Merged
LukasKalbertodt added a commit that referenced this issue Mar 19, 2024
@LukasKalbertodt
Add series to search results (#1144)
7895f81 
This adds series to search results.

Couple of notes:
- I don't really like the icon chosen for this, but the one I would
prefer is not yet included in the icon package used in Tobira.
- The box shadow for the thumbnails is also debatable. I left it in so
you can play around with it and see if you can find a nicer looking one.
- The series entries look samewhat empty when there is no description,
but we discussed adding some metadata like a (potentially shortened)
list of creators of events in that series and maybe also/alternatively
direct links to the first few events, but this is tbd in another PR.

Closes #360
@github-project-automation github-project-automation bot moved this from Todo to Done ✔️ in Tobira Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:frontend Everything frontend related area:search Related to Tobira's search kind:new-feature A new feature
Projects
Tobira
Status: Done ✔️
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add series to search results owi92/tobira
2 participants
@oas777 @LukasKalbertodt