-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slide segments and extracted text to harvesting and DB, enable paella slide previews #1163
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Just code review, no testing yet)
Looks overall pretty good. I have a few small nits, but there is only one bigger one: about how to store the startTime
.
This pull request has conflicts ☹ |
Quick note for everyone: due to how our test deployment works, existing videos will not have segments shown in our Tobira test deployments. Until the next Tobira release happens: then everything works as expected. Also: we can manually run a resync on the test deployment and sometimes we might do that, so it might work randomly. Don't let this confuse you :D |
This adds the ocr'd slide texts as well as a list of timestamped frames to the harvesting sync code and stores them in the DB.
In order the show the slide previews,
paella-slide-plugins
was added and configured to use the timestamped frames.Needs opencast/opencast#5757 to work. Once that is merged, released and used on our test Opencast, the changes can be tested with fresh uploads. We'll still need some mechanism to apply segmentation and ocr (and speech-to-text as well) to existing videos.
(Can be reviewed commit by commit, though note that the migration from the second commit was extended in the third)