Fix building Tobira on macOS #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, the `--quiet` flag wasn't necessary or doing anything critical.
Gathering memory info seems to be more involved on macOS, and since it is non-critical, ignoring it is a simple workaround that allows development on these platforms.
On macOS, the `sleep` command doesn't work with quantifiers like `s`, `m`, `h`, but always assumes seconds. Therefore we need to omit any quantifiers and convert larger time quantities accordingly.
owi92
force-pushed
the
config-macos-build
branch
from
eecef75
to
5e0b19e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables building tobira on macOS by not gathering procfs memory info on non-linux systems.
It also fixes the
usage: sleep secondserror - apparently, thesleepcommand doesn't work with quantifiers on macOS.