Improve "gallery view" of series block #737
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the second commit message for the main attraction:
The first commit refactors those components to make the second commit possible. The refactoring makes it so that all "view dependent" CSS code is actually contained in the respective
*View
component, not conditionally insideItem
.Regarding the main style change: I'm really interested in just feedback. The video items certainly grew in size on average. It's still smaller than on YouTube. I'm not sure if the max width is too overwhelming? I'm also not sure if distributing the left-over space to each item instead of all at the end is an improvement? I'm open to suggestions. Of course, this is something that can be fine-tweaked a lot to make certain screen sizes look better.