Fix db clear by not dropping automatically created array types
#893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For each type that we create, postgres adds an additional "array" type
of that type. Trying to drop that array type fails with:
ERROR: cannot drop type block_type[] because type block_type requires it
HINT: You can drop type block_type instead.
Deleting the base type also gets rid of the array type. The filter added
in this commit seems to do the trick and should work generally. Related:
https://www.postgresql.org/docs/current/catalog-pg-type.html
Note that this error occurs only occasionally, depending on what order
the type names are returned from our query. In all my tests, the base
types were ordered before the array types, hiding the problem. On a
production instance, they were ordered differently, that's how I
noticed this bug.
owi92
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each type that we create, postgres adds an additional "array" type of that type. Trying to drop that array type fails with:
Deleting the base type also gets rid of the array type. The filter added in this commit seems to do the trick and should work generally. Related: https://www.postgresql.org/docs/current/catalog-pg-type.html
Note that this error occurs only occasionally, depending on what order the type names are returned from our query. In all my tests, the base types were ordered before the array types, hiding the problem. On a production instance, they were ordered differently, that's how I noticed this bug.