Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @opencast/appkit #902

Merged
merged 5 commits into from
Jul 13, 2023
Merged

Use @opencast/appkit #902

merged 5 commits into from
Jul 13, 2023

Conversation

LukasKalbertodt
Copy link
Member

@LukasKalbertodt LukasKalbertodt commented Jul 6, 2023

This switches to @opencast/appkit, a library that will deduplicate all shared code between Tobira, Studio and Editor. Appkit is not nearly done yet, but I released the first version and it can already be integrated here. Nothing user-visible should change by doing this.

This commit replaces the floating and color scheme functionality with
that of appkit.
@LukasKalbertodt LukasKalbertodt added the changelog:dev Changes primarily for developers label Jul 6, 2023
@github-actions github-actions bot temporarily deployed to test-deployment-pr902 July 6, 2023 13:18 Destroyed
@LukasKalbertodt LukasKalbertodt marked this pull request as ready for review July 12, 2023 15:02
@github-actions github-actions bot temporarily deployed to test-deployment-pr902 July 12, 2023 15:06 Destroyed
Copy link
Member

@owi92 owi92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing (see my other comment).

I also noticed that the dark mode floating menus on mobile are now using the correct grey, that is good 👍
(tbh, I didn't realize that they weren't before).

frontend/src/relay/auth.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to test-deployment-pr902 July 12, 2023 16:52 Destroyed
@owi92 owi92 merged commit 9875617 into elan-ev:master Jul 13, 2023
2 checks passed
@LukasKalbertodt LukasKalbertodt deleted the appkit branch July 13, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:dev Changes primarily for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants