Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return label to studio link #928

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

owi92
Copy link
Member

@owi92 owi92 commented Sep 6, 2023

Closes #910

This adds a return label to the query parameters of Tobira's studio link. With this, studio users coming from Tobira will see where they are returning to after finishing their studio work.

@github-actions github-actions bot added the status:conflicts This PR has conflicts that need to be resolved label Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions bot removed the status:conflicts This PR has conflicts that need to be resolved label Sep 6, 2023
@owi92 owi92 added the changelog:user User facing changes label Sep 8, 2023
@github-actions github-actions bot temporarily deployed to test-deployment-pr928 September 11, 2023 12:25 Destroyed
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A thought and a question :P

frontend/src/relay/auth.tsx Outdated Show resolved Hide resolved
params={{ "return.target": new URL(document.location.href) }}
params={{
"return.target": new URL(document.location.href),
"return.label": "Tobira",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So mh, is "Tobira" the right string to pass there? Do you think the video portal name from the settings (which is shown as title of the root realm) is better? It could be quite long though, mhhh....

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think that might actually be better than just "Tobira". Might be long, sure, but hopefully institutions won't configure a name that is too long (I think that would also look a bit awkward on the homepage).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be long, sure, but hopefully institutions won't configure a name that is too long (I think that would also look a bit awkward on the homepage).

https://tobira.unibe.ch/
"Video Portal University of Bern (Tobira)"

image

^ @dagraf :P

Ok seriously, I think Bern's title is still fine on the home page but might be a little bit crammed in the studio button. But oh well. Studio could also just limit the length of the button label. So yeah, let's do it like this.

@github-actions github-actions bot temporarily deployed to test-deployment-pr928 September 11, 2023 14:59 Destroyed
@LukasKalbertodt LukasKalbertodt merged commit 03e5289 into elan-ev:master Sep 11, 2023
2 checks passed
@owi92 owi92 deleted the send-label-to-studio branch March 4, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:user User facing changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tobira seems not to send a label to Opencast Studio when opening it
2 participants