Do not include `"email": null` in JWT (if there is no email) #964

LukasKalbertodt · 2023-10-18T12:28:53Z

Just a tiny thing I noticed recently. ~~Note for testing: jose does not have an email, everyone else does.~~ nevermind, Jose is not allowed to request JWTs... mhpf.

This just makes the JWTs larger.

owi92

Yeah as you mentioned, there is no way of testing this for users without email, but also no need to I think, since the email thing was just added recently anyway.

Do not include "email": null in JWT (if there is no email)

cabdca0

This just makes the JWTs larger.

LukasKalbertodt added the changelog:admin Changes primarily for admins label Oct 18, 2023

github-actions bot temporarily deployed to test-deployment-pr964 October 18, 2023 12:45 Destroyed

owi92 approved these changes Oct 20, 2023

View reviewed changes

owi92 merged commit bd6d6b6 into elan-ev:master Oct 20, 2023
3 checks passed

LukasKalbertodt deleted the smaller-jwts branch October 23, 2023 08:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not include `"email": null` in JWT (if there is no email) #964

Do not include `"email": null` in JWT (if there is no email) #964

LukasKalbertodt commented Oct 18, 2023 •

edited

owi92 left a comment •

edited

Do not include "email": null in JWT (if there is no email) #964

Do not include "email": null in JWT (if there is no email) #964

Conversation

LukasKalbertodt commented Oct 18, 2023 • edited

owi92 left a comment • edited

Choose a reason for hiding this comment

Do not include `"email": null` in JWT (if there is no email) #964

Do not include `"email": null` in JWT (if there is no email) #964

LukasKalbertodt commented Oct 18, 2023 •

edited

owi92 left a comment •

edited