Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single 2018 edition crate #364

Merged
merged 2 commits into from Jul 2, 2019
Merged

Single 2018 edition crate #364

merged 2 commits into from Jul 2, 2019

Conversation

KodrAus
Copy link
Member

@KodrAus KodrAus commented Jun 26, 2019

This PR updates the codebase to the 2018 edition and merges the distinct crates into one. We're hitting limitations with multiple crates for very little benefit, so merging them will let us hide more implementation details, and use standard types across the distinct features.

@KodrAus
Copy link
Member Author

KodrAus commented Jul 1, 2019

I'm also working in some 7.0 support into this PR, but while our integration test coverage is still sparse (we should try convert all the response parsing tests into proper integration tests) there are probably still a lot of holes.

@KodrAus
Copy link
Member Author

KodrAus commented Jul 1, 2019

The docs need some more work, they still refer to the old crate layout, but once this is green I'll merge it in so we have something consistent to work off.

@KodrAus
Copy link
Member Author

KodrAus commented Jul 1, 2019

Ok there’s progress on the build. We have an issue with the sniffed nodes test where it’s not properly shutting down, even though it should be.

I’m also interested in a few more module refactorings:

mod endpoints {}
mod params {}

mod client {
    mod requests {}
    mod responses {}
}

mod http {
    mod sender {}
    mod receiver {}
}

So that it’s clearer where the high-level and low-level details live.

@KodrAus KodrAus changed the title [WIP] Single 2018 edition crate Single 2018 edition crate Jul 2, 2019
This was referenced Jul 2, 2019
@KodrAus KodrAus merged commit 0f90521 into master Jul 2, 2019
@KodrAus KodrAus deleted the feat/2018-edition branch July 2, 2019 03:55
@mwilliammyers
Copy link
Collaborator

Wow, this looks awesome! Much easier to navigate.

Thanks for this PR and such an amazing crate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants