Expose highlight in Hit
#366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KodrAus
reviewed
Jun 30, 2019
|
|
||
| [highlighted]: https://www.elastic.co/guide/en/elasticsearch/reference/current/search-request-highlighting.html | ||
| */ | ||
| pub fn into_highlight(&self) -> Option<Value> { |
There was a problem hiding this comment.
Do we need this method? I think you could just call response.highlight().cloned() and get the same result.
|
Thanks for the PR @mwilliammyers! I've just left one comment but otherwise this looks good to me. I'm currently refactoring the crate layouts to also fix up the build so am not too concerned about Travis here right now. |
|
Hey @mwilliammyers 👋 I've got a big changeset to merge in #364 but don't want you to have to deal with rebasing. So I'm going to merge this one as-is and drop off the Thanks again for working on this and bearing with the rather ad-hoc state of this codebase! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went ahead with option 1 just to be safe in case Elasticsearch returns different things... but I can change it and update this PR.
Closes #365