Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Template log4j.properties for ES v7 #598

Closed
wants to merge 3 commits into from

Conversation

fabiogermann
Copy link

Introduce changes for the logging property file to be compatible with ES v7

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@elasticcla
Copy link

Hi @fabiogermann, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in your Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

replaced iteritems() with items()
@jmlrt
Copy link
Member

jmlrt commented Sep 4, 2019

jenkins test this please

@jmlrt
Copy link
Member

jmlrt commented Sep 5, 2019

jenkins test this please

@jmlrt
Copy link
Member

jmlrt commented Sep 5, 2019

Hi @fabiogermann,
Thank you for your PR ❤️

While updating log4j template for Elasticsearch 7.X is really useful, I wonder if we still need to maintain a specific log4j template into this Ansible role.

After a quick review of the template I don't see any dynamic values inside except conditionals related to Elasticsearch version.

Maybe we should instead keep the log4j2.properties file already provided by Elasticsearch packages which is always up to date. WDYT?

@jmlrt
Copy link
Member

jmlrt commented Sep 5, 2019

related to #577

@botelastic
Copy link

botelastic bot commented Dec 4, 2019

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
To track this PR (even if closed), please open a corresponding issue if one does not already exist.

@jmlrt
Copy link
Member

jmlrt commented Dec 5, 2019

I'm closing this PR as we handled it with #637

@jmlrt jmlrt closed this Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants