This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Use default config files #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The log4j configuration template provided by this ansible role doesn't reflect current log4j configuration in elasticsearch 6.x and 7.x. Also this template doesn't contain any variable so everything is hardcoded inside. As we don't need to override any value inside, let's use standard elasticsearch log4j configuration file provided by elasticsearch package and stop overriding it with this role.
This option doesn't seem to exists anymore in elasticsearch. It's not present in current versions of system configuration provided by recent elasticsearch packages and there is no code using it inside elasticsearch.
|
jenkins test this please |
…kage This is removing lot of options deprecated since 6.0 like ES_JVM_OPTIONS, CONF_DIR, DATA_DIR and LOG_DIR (https://www.elastic.co/guide/en/elasticsearch/reference/6.0/breaking_60_packaging_changes.html)
The jvm options template provided by this ansible role doesn't reflect current log4j configuration in elasticsearch 6.x and 7.x. This commit update it to default version provided in 6.x and 7.x elasticsearch standard packages.
jmlrt
force-pushed
the
use-default-config-files
branch
2 times, most recently
from
f72510d
to
06009f5
Compare
|
Ubuntu 14.04 failures aren't related => created test-kitchen/kitchen-docker#353 for that |
|
I have a really strange permissions issue with this PR:
I don't see any change which could give these strange permissions... |
|
@jmlrt maybe try putting all the
|
From Ansible doc (https://docs.ansible.com/ansible/latest/modules/template_module.html#template-module) For those used to /usr/bin/chmod remember that modes are actually octal numbers. You must either add a leading zero so that Ansible's YAML parser knows it is an octal number (like 0644 or 01777) or quote it (like '644' or '1777') so Ansible receives a string and can do its own conversion from string into number. Giving Ansible a number without following one of these rules will end up with a decimal number which will have unexpected results.
jmlrt
force-pushed
the
use-default-config-files
branch
from
3c6b822
to
bc7fc40
Compare
|
Finally tests are OK (except ubuntu-1404 due to #637 (comment))! @Conky5 @fatmcgav @Crazybus This is ready for review. |
Crazybus
reviewed
Dec 2, 2019
…lasticsearch into use-default-config-files
This was referenced Dec 5, 2019
This was referenced Dec 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lot of ES config files templates provided by this role weren't up to date with files provided by standard elasticsearch 6.x and 7.x packages.
This PR fix that by using standard config file provided by elasticsearch package when possible (
log4j2.properties) or updating templates to reflect new versions provided by elasticsearch packages (/etc/sysconfig/elasticsearch,/etc/default/elasticsearchandjvm.options).This is also removing some options deprecated since 6.0.
Also allow to fully override these files by providing custom files.
Related to #631, #628, #598, #577 and #400 and https://discuss.elastic.co/t/es-6-8-vs-7-4-memory-issues/202849