New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASP.NET Core request body capturing erases the body #460
Comments
Here we have the test that covers this feature - the test case is a bit simpler, I don't see yet how it makes a difference, but as it seems it does make a difference. |
This works fine if I comment out |
Hi! I am using the latest version and continues with this problem. "ElasticApm": { |
You are right! All tests passed when comment this line. I think is not necessary to do this and an accepted pull request. https://devblogs.microsoft.com/aspnet/re-reading-asp-net-core-request-bodies-with-enablebuffering/ I need this ASAP so i'll pull a request, okay? Thank you!
|
This solves: #539 |
Thanks for the help everyone! The PR from @iquirino (#539) seems ok to me, very much appreciated! I also opened #542 - as mentioned our existing automated test did not discover this issue. I was unable to repro it with the way we tested previously. On the other hand hosting the sample app with |
When it will be available on nugget? |
We don't have a fix date for the next release, so unfortunately I can't tell you a specific date. |
I'm running a version from my computer because this broken my production environment. |
Add test covering #460 - making sure capturing request body does not erase the body
I'm very sorry about that! To be fair: this feature is off by default and you could immediately recover by turning the feature off, right? Or do I miss something? Not that I want to make this sound like a non-issue - it was indeed an important fix-, but I want to make sure I see the impact of this correctly. The release is out: https://github.com/elastic/apm-agent-dotnet/releases/tag/1.1.2 Version |
Uhull! You are awesome! Thank you Greg! |
Reported here by @brezaie.
Reproducer also included in the comment - copying here:
"CaptureBodyContentTypes": "application/x-www-form-urlencoded*, text/*, application/json*, application/xml*",
Without agent the
filter
parameter is populated, once the agent is activated it becamenull
.The text was updated successfully, but these errors were encountered: