Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request body does not need old copy #539

Merged
merged 1 commit into from Oct 9, 2019
Merged

Request body does not need old copy #539

merged 1 commit into from Oct 9, 2019

Conversation

iquirino
Copy link
Contributor

@iquirino iquirino commented Oct 9, 2019

The result of a EnableRewind is a valid Request.Body

All tests passed.

https://devblogs.microsoft.com/aspnet/re-reading-asp-net-core-request-bodies-with-enablebuffering/

@iquirino
Copy link
Contributor Author

iquirino commented Oct 9, 2019

githubPrCheckApproved: The PR is not approved yet

@gregkalapos gregkalapos self-assigned this Oct 9, 2019
@gregkalapos
Copy link
Contributor

Thanks @iquirino, I'll take a look at it.

@gregkalapos gregkalapos self-requested a review October 9, 2019 10:59
Copy link
Contributor

@gregkalapos gregkalapos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @iquirino! LGTM.

👍

@codecov-io
Copy link

Codecov Report

Merging #539 into master will decrease coverage by 1.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #539      +/-   ##
==========================================
- Coverage   84.01%   82.57%   -1.45%     
==========================================
  Files         101      101              
  Lines        4480     3942     -538     
==========================================
- Hits         3764     3255     -509     
+ Misses        716      687      -29
Impacted Files Coverage Δ
...tic.Apm.AspNetCore/Extensions/RequestExtentions.cs 62.06% <ø> (-22.15%) ⬇️
src/Elastic.Apm/Helpers/PlatformDetection.cs 59.25% <0%> (-13.7%) ⬇️
src/Elastic.Apm/Api/User.cs 33.33% <0%> (-6.67%) ⬇️
src/Elastic.Apm/Helpers/TimeUtils.cs 85.71% <0%> (-5.2%) ⬇️
src/Elastic.Apm/Helpers/AgentTimer.cs 83.33% <0%> (-5.13%) ⬇️
.../Metrics/MetricsProvider/SystemTotalCpuProvider.cs 63.01% <0%> (-4.99%) ⬇️
src/Elastic.Apm.AspNetCore/ApmMiddleware.cs 80.27% <0%> (-4.57%) ⬇️
...nfig/AbstractConfigurationWithEnvFallbackReader.cs 88.46% <0%> (-4.04%) ⬇️
src/Elastic.Apm/Helpers/Assertion.cs 82.6% <0%> (-3.88%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d0949a...1247981. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants