Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure BreakdownMetricsProvider prints 1K warning only once per collection #1367

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Make sure BreakdownMetricsProvider prints 1K warning only once per collection #1367

merged 1 commit into from
Aug 4, 2021

Conversation

gregkalapos
Copy link
Contributor

Solves #1361

Prior to this PR once BreakdownMetricsProvider reached the 1K metricset limit, it pinted a warning after each transaction. With a high number of transactions this can span logs.

This PR changes this to print this log only once in every metics collection round. So in every MeticInterval (by default 30sec) we'll print the warning once if the 1K limit is reached. This also reflects reality better, since once the 1K limit is reached, we reset it after the current List<MetricSet> is sent to the server.

@apmmachine
Copy link
Contributor

apmmachine commented Aug 2, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-04T06:53:35.869+0000

  • Duration: 50 min 57 sec

  • Commit: 559a47e

Test stats 🧪

Test Results
Failed 0
Passed 19649
Skipped 126
Total 19775

Trends 🧪

Image of Build Times

Image of Tests

Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregkalapos gregkalapos merged commit 8164531 into elastic:master Aug 4, 2021
@gregkalapos gregkalapos deleted the ChangeLogInBreakdownMetricsProvider branch August 4, 2021 09:11
@SbiCA
Copy link

SbiCA commented Aug 9, 2021

Any chance that this fix will be released soon? It really creates noise in the logs

@russcam russcam added v1.11.1 bug Something isn't working labels Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-dotnet bug Something isn't working v1.11.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants