Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snapshotty now release correctly calls profiler-zip #2045

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Apr 5, 2023

No description provided.

@Mpdreamz
Copy link
Member Author

Mpdreamz commented Apr 5, 2023

This is now failing on main because pack now calls the proper overload to Target()

6e614ef#diff-607d2b46c588a5020c6bb4d41f1c60efdfc4f08edebba3ca23d7c0e4467d60b7R113

Making them dependencies of pack, not arguments to the pack Target 👀

@apmmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-04-05T12:56:12.322+0000

  • Duration: 75 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 2536
Skipped 33
Total 2569

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@Mpdreamz
Copy link
Member Author

Mpdreamz commented Apr 5, 2023

Self reviewing this @gregkalapos

@Mpdreamz Mpdreamz merged commit c69b820 into main Apr 5, 2023
@Mpdreamz Mpdreamz deleted the fix/snapshoty-linux branch April 5, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants