Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send domain name when detected #2067

Merged
merged 5 commits into from
Jul 12, 2023
Merged

Send domain name when detected #2067

merged 5 commits into from
Jul 12, 2023

Conversation

stevejgordon
Copy link
Contributor

@stevejgordon stevejgordon commented May 9, 2023

Fixes #2065.

A reference implementation for elastic/apm#795.

@apmmachine
Copy link
Collaborator

apmmachine commented May 9, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-05-11T06:52:53.903+0000

  • Duration: 74 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 2536
Skipped 33
Total 2569

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@stevejgordon stevejgordon marked this pull request as ready for review June 30, 2023 10:50
@stevejgordon
Copy link
Contributor Author

I think this is ready for review depending on any changes needed as an outcome of this discussion.

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but not sure why Elastic.Apm.MongoDb got changed?

@stevejgordon stevejgordon merged commit 43479ee into main Jul 12, 2023
14 checks passed
APM-Agents (OLD) automation moved this from In Progress to Done Jul 12, 2023
@stevejgordon stevejgordon deleted the issue-2065-host-domain branch July 12, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[META 793] Report FQDN for detected_hostname
3 participants