-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metadata spec with host domain name information #795
Conversation
The piece I'm less certain of is the final paragraph. Arguably the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it would be relevant to add in this spec the OS-specific ways to capture the hostname / FQDN ?
I know most of the time we will rely on platform-specific APIs, but it would definitely help implementation to have at least one or more strategy described per OS to:
- get a consistent reference value that we can use for testing (manual or automated)
- provide a fallback option in case an equivalent platform API is not available.
Co-authored-by: SylvainJuge <763082+SylvainJuge@users.noreply.github.com>
Yes, that's a good suggestion. I captured an example of what .NET does in Slack, but I will add and expand on that here to describe possible options for accessing this information. |
@SylvainJuge Added reference implementation details as suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed this with the server team.
We might simplify by requiring all APM agents just to report the fqdn for the hostname instead.
IMPORTANT UPDATE after more discussions and clarifications: We keep it simple for APM agents. This change only requires the APM agents to always report the FQDN (instead of the simple) for the detected_hostname field. Closing this PR as it is not relevant anymore in that form. |
Per #793 - "ECS changed the definition of
host.name
and encourages to use the fully qualified domain name for the host name". This PR updates the metadata spec with a proposed section detailing how clients should send the domain information required by APM server.sanitize_field_names
)CODEOWNERS
)To auto-merge the PR, add
/
schedule YYYY-MM-DD
to the PR description.Closes #794