-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend dependencies granularity for NoSQL and Messaging #2104
Conversation
a2bb1b8
to
efbdf67
Compare
@Mpdreamz This is ready for review but is blocked as I do not currently have Azure access to run the updated Azure tests. Once these are enabled again in CI, we can run them there, or if one of us has access to run them locally, that should be sufficient for now. |
BREAKING: This removes the setting of context.db.instance and context.db.statement to align with the spec. Adds span assertions to validate specification conditions are met for spans.
- We now attach HTTP info to the context for the main span. BREAKING: - The action has been changed to 'request' to align with the spec. - The db.instance is no longer set. The spec recommends that this can be determined on cloud using `x-found-handling-cluster` but we don't have a way to access the headers from the client diagnostics (v7). Notes: `db.statement` impl has not been changed to align with the spec. That will be future work.
Includes a rename of `DisabledOnWindowsDockerFact` to include CI in the name so it is more explicit. These tests runs correctly on Windows when Docker is available.
b8eb193
to
ef4052c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small note other than that LGTM
b6afc27
to
e08d730
Compare
Fixes #1754
This PR aligns more closely with the specification.
BREAKING:
context.db.instance
andcontext.db.statement
to align with the spec.db.instance
is no longer set. The spec recommends that this be determined on Elastic Cloud usingx-found-handling-cluster
, but we don't have a way to access the headers from the client diagnostics (v7).Notes:
For Elasticsearch, the
db.statement
implementation has not been changed to align with the spec as that requires more extensive changes and will be addressed as part of #1785.Includes