Move Redis Profiler registration to ConditionalWeakTable #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should ensure we don't leak our registrations if span/transaction's Ended event never gets called but the spans/transaction themselves get GC'ed.
Mpdreamz
commented
Aug 4, 2023
|
|
||
| private readonly Lazy<IApmLogger> _logger; | ||
| private readonly Lazy<IApmAgent> _agent; | ||
| private static readonly Func<object, object> MessageFetcher; |
There was a problem hiding this comment.
This is a continuation of #2104 since we no longer set db.instance cc @stevejgordon
gregkalapos
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should ensure we don't leak our registrations if span/transaction's Ended
event never gets called but the spans/transaction themselves get GC'ed.
Note: I could not reproduce the memory leak as
Endedwas always called.Fixes: #2145