Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs sample code with correct constant class name #289

Merged
merged 2 commits into from
Jun 17, 2019
Merged

Fix docs sample code with correct constant class name #289

merged 2 commits into from
Jun 17, 2019

Conversation

lafriks
Copy link
Contributor

@lafriks lafriks commented Jun 17, 2019

No description provided.

lafriks and others added 2 commits June 17, 2019 15:25
Use ApiConstants, since Transaction.TypeRequest isn't there anymore.
Copy link
Contributor

@gregkalapos gregkalapos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lafriks!

I pushed another commit doing the same for Transaction.

I think this is ok to merge. @bmorelli25 please also take a look, thx!

@gregkalapos
Copy link
Contributor

@lafriks could you please sign our CLA with the email address that you used for you commit? Thank you!

@lafriks
Copy link
Contributor Author

lafriks commented Jun 17, 2019

@gregkalapos done

@codecov-io
Copy link

codecov-io commented Jun 17, 2019

Codecov Report

Merging #289 into master will increase coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
+ Coverage   79.06%   79.32%   +0.25%     
==========================================
  Files          71       71              
  Lines        2365     2327      -38     
  Branches      420      427       +7     
==========================================
- Hits         1870     1846      -24     
+ Misses        321      302      -19     
- Partials      174      179       +5
Impacted Files Coverage Δ
.../Elastic.Apm/Config/AbstractConfigurationReader.cs 72.64% <0%> (-2.25%) ⬇️
src/Elastic.Apm/Agent.cs 70.83% <0%> (-1.67%) ⬇️
....Apm/Report/Serialization/PayloadItemSerializer.cs 100% <0%> (ø) ⬆️
src/Elastic.Apm/Config/ConfigConsts.cs 100% <0%> (ø) ⬆️
src/Elastic.Apm/Helpers/SystemInfoHelper.cs 78.33% <0%> (+1.66%) ⬆️
...rics/MetricsProvider/FreeAndTotalMemoryProvider.cs 68.65% <0%> (+5.19%) ⬆️
src/Elastic.Apm/Api/Service.cs 94.73% <0%> (+7.64%) ⬆️
src/Elastic.Apm/Model/CapturedException.cs 80% <0%> (+33.33%) ⬆️
src/Elastic.Apm/Api/System.cs 100% <0%> (+33.33%) ⬆️
src/Elastic.Apm/Model/SpanCount.cs 100% <0%> (+55.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf4ae74...d492131. Read the comment docs.

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📗

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📗

@gregkalapos gregkalapos merged commit c9ab3bc into elastic:master Jun 17, 2019
@lafriks lafriks deleted the fix/docs_consts branch June 18, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants