Report kubernetes system metadata

[vhatsura]

closes #181

TBD:

• tests
• documentation

[vhatsura]

@bmorelli25, I don't sure do we need to add it into documentation? I found nothing in other agents related to it.

[bmorelli25]

We document Kubernetes metadata centrally, in APM Server: https://www.elastic.co/guide/en/apm/server/master/metadata-api.html. I don't think anything is needed in this PR 👍

[vhatsura]

@gregkalapos, I'll very much appreciate it if you can review the PR.

[gregkalapos]

Hey @vhatsura - sorry for the delay, currently we are fighting with some CI issues; hopefully we can get back to normal soon. Once master is green again I'll make sure PRs gets reviewed and merged.

[vhatsura]

@gregkalapos, just a kindly reminder. Would be nice to have such feature in the next release

[ejsmith]

Bump

[apmmachine]

💚 Build Succeeded

Expand to view the summary

Build stats

• Build Cause: [Pull request Report kubernetes system metadata #741 updated]

• Start Time: 2020-04-28T19:34:45.968+0000

• Duration: 62 min 23 sec (3743311)

• Commit: fdcc313

Test stats 🧪

Test	Results
Failed	0
Passed	13495
Skipped	0
Total	13495

Steps errors

Expand to view the steps failures

• Name: Docker Build

  • Description:

  • Result: FAILURE

  • Duration: 0 min 4 sec<

  • Start Time: 2020-04-28T19:42:40.152+0000

[gregkalapos]

Thanks @vhatsura - looks good to me.

Some of these can be also collected by parsing /proc/self/cgroup - this is a super useful comment on that. Here is some more info on that.

The Go PR has some sample /proc/self/cgroup that we could also steal for testing.

This is already good progress and I think it's ok to merge - if you feel you can follow up with parsing /proc/self/cgroup later.

[gregkalapos]

I'd have either called all 3 methods here directly or also stored the result of ParseKubernetesInfo(containerInfo, hostName) in a variable and assigned that to Kubernetes similar to the two other properties.

But that's just a cosmetic thing - this is totally fine this way too.

[vhatsura]

Yeap, it makes sense. Fixed