Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for v2 API #175

Closed
10 tasks done
axw opened this issue Aug 8, 2018 · 2 comments
Closed
10 tasks done

Implement support for v2 API #175

axw opened this issue Aug 8, 2018 · 2 comments

Comments

@axw
Copy link
Member

axw commented Aug 8, 2018

Related: elastic/apm-server#1237

@axw
Copy link
Member Author

axw commented Sep 3, 2018

  • Won't bother parsing the error responses for now. We just log them as-is.
  • I'm going to see how we go with leaving the timeout as it is: from connection to response. Given a default request time of 10 seconds, this leaves 20 seconds for connection and server response, which should be fine.

@axw
Copy link
Member Author

axw commented Sep 3, 2018

Tested opbeans-go, with #197. All looks good, closing this.

@axw axw closed this as completed Sep 3, 2018
@axw axw removed the [zube]: Done label Sep 7, 2018
@alvarolobato alvarolobato added this to the 1.0 milestone Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants