Core v2 protocol support #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump version to 0.5.0
Add a new package, internal/iochan, which provides a channel-based io.Reader. This is used for streaming to the transport.
Introduce a new package, internal/ringbuffer, which provides a cyclic queue for storing blocks of bytes. Each block is preceded by 4 bytes encoding the block length. If the buffer lacks capacity for a new block, the oldest blocks are first evicted.
Implementation of elasticapm.Logger, backed by either a *testing.T or *testing.B.
Transport now has a single SendStream method, which starts sending a stream of data to the /v2/intake endpoint. The body is an io.Reader, and is expected to be zlib-compressed.
The tracer now streams data, through a zlib compressor, to an active request. If there is no active request, entities are encoded to JSON and stored, uncompressed, in a ring buffer.
Codecov Report
@@ Coverage Diff @@
## v2 #180 +/- ##
=========================================
+ Coverage 75.37% 80.8% +5.42%
=========================================
Files 86 85 -1
Lines 5352 5120 -232
=========================================
+ Hits 4034 4137 +103
+ Misses 1128 775 -353
- Partials 190 208 +18
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the bulk of the v2 protocol. We still need to move spans to the top level, and some more testing is required around buffer and request sizes.