Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add write permission to labeler job #1581

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Add write permission to labeler job #1581

merged 1 commit into from
Mar 12, 2024

Conversation

dmathieu
Copy link
Member

The labeler needs to have the pull-request: write permission, so it can assign labels on PRs.

See https://github.com/elastic/apm-agent-go/actions/runs/8246861649/job/22553967383?pr=1580

@dmathieu
Copy link
Member Author

Since the labeler runs on pull_request_target, I think we won't see any change until the PR is merged (which is also why we didn't see any in #1575)

cc @reakaleek

@dmathieu dmathieu marked this pull request as ready for review March 12, 2024 10:12
@dmathieu dmathieu requested a review from a team as a code owner March 12, 2024 10:12
@reakaleek
Copy link
Member

Thank you for the fix!

@reakaleek reakaleek enabled auto-merge (squash) March 12, 2024 11:28
@reakaleek reakaleek merged commit f808a26 into main Mar 12, 2024
13 of 14 checks passed
@dmathieu dmathieu deleted the labeler-pr-write branch March 12, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v1v v1v v1v approved these changes

@reakaleek reakaleek reakaleek approved these changes

@kruskall kruskall kruskall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmathieu @reakaleek @v1v @kruskall