apm: remove Context.SetCustom #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the ability to set custom context from instrumentation modules. It's unclear whether we will retain this feature, or consolidate on tags. Until we've made a decision on that, we'll keep it out of the API for new agents.
axw
force-pushed
the
remove-custom-context
branch
from
9c9d0df
to
3b8ec38
Compare
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
==========================================
- Coverage 80.45% 80.43% -0.03%
==========================================
Files 97 97
Lines 5665 5613 -52
==========================================
- Hits 4558 4515 -43
+ Misses 844 838 -6
+ Partials 263 260 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the ability to set custom context from
instrumentation modules. It's unclear whether
we will retain this feature, or consolidate on
tags. Until we've made a decision on that, we'll
keep it out of the API for new agents.
Closes #282