Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module/apmgrpc: fix trace propagation vs. sampling #602

Merged
merged 2 commits into from
Jul 31, 2019
Merged

module/apmgrpc: fix trace propagation vs. sampling #602

merged 2 commits into from
Jul 31, 2019

Commits on Jul 30, 2019

  1. apmtest: add RecordingTracer.WithTransaction 

    Add WithTransaction and WithTransactionOptions
methods to RecordingTracer, and update the
top-level functions to be implemented in terms
of them. This enables calling those functions
with a customised tracer.
    @axw
    axw committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    e6a0136 View commit details
    Browse the repository at this point in the history

  2. module/apmgrpc: fix trace propagation vs. sampling 

    Fix a bug in the client interceptor which would break
trace propagation when facing dropped spans or non-sampled
transactions. In these cases we should propagate the
transaction's trace context, rather than sending nothing
in the outgoing metadata which would restart tracing.
    @axw
    axw committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    faf2be7 View commit details
    Browse the repository at this point in the history