Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only remove domain when FQDN is expected #2286

Merged
merged 3 commits into from
Nov 25, 2021

Conversation

eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Nov 24, 2021

Fixes #2284

@eyalkoren eyalkoren added the bug Bugs label Nov 24, 2021
@eyalkoren eyalkoren requested review from jackshirazi and removed request for SylvainJuge November 24, 2021 15:40
@eyalkoren eyalkoren mentioned this pull request Nov 24, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Nov 24, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-25T13:27:19.210+0000

  • Duration: 68 min 25 sec

  • Commit: f1f0881

Test stats 🧪

Test Results
Failed 0
Passed 2546
Skipped 21
Total 2567

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run compatibility tests : Run the JDK Compatibility test.

  • run integration tests : Run the APM-ITs.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@SylvainJuge SylvainJuge added the await-release Mark issues that depend on next release, or PRs that are planned to be included label Nov 24, 2021
@SylvainJuge
Copy link
Member

I've just found that there was another minor issue with using external commands, the output is not trimmed, thus locally I got (on linux) myhostname\n and it's sent as-is to apm-server 🤦.

@SylvainJuge SylvainJuge merged commit 3752548 into elastic:master Nov 25, 2021
@felixbarny felixbarny mentioned this pull request Nov 29, 2021
4 tasks
@SylvainJuge SylvainJuge removed the await-release Mark issues that depend on next release, or PRs that are planned to be included label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About hostname
4 participants