Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] setup with docker image #2956

Merged
merged 8 commits into from
Jan 12, 2023
Merged

[doc] setup with docker image #2956

merged 8 commits into from
Jan 12, 2023

Conversation

SylvainJuge
Copy link
Member

What does this PR do?

  • documents adding the agent with docker image
  • fix a typo

Checklist

@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) Jan 10, 2023
@apmmachine
Copy link
Collaborator

apmmachine commented Jan 10, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-12T08:38:30.372+0000

  • Duration: 7 min 8 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@SylvainJuge SylvainJuge added the docs Documentation label Jan 11, 2023
@SylvainJuge SylvainJuge marked this pull request as ready for review January 11, 2023 17:20
@github-actions
Copy link

/test

eyalkoren
eyalkoren approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@eyalkoren eyalkoren left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition, only some minor wording suggestions.
I think we are still missing a top level section, but this can be done in a separate PR. Maybe for now only add a header within the main setup page that links to what you added.

docs/setup-javaagent.asciidoc Outdated Show resolved Hide resolved
docs/setup/get-agent.asciidoc Outdated Show resolved Hide resolved
docs/setup/get-agent.asciidoc Outdated Show resolved Hide resolved
SylvainJuge and others added 2 commits January 12, 2023 09:36
@SylvainJuge @eyalkoren
Apply suggestions from code review
90cb18a 
Co-authored-by: eyalkoren <41850454+eyalkoren@users.noreply.github.com>
@SylvainJuge
post-review change
e3e884b
@SylvainJuge SylvainJuge merged commit 835ec87 into elastic:main Jan 12, 2023
APM-Agents (OLD) automation moved this from In Progress to Done Jan 12, 2023
@SylvainJuge SylvainJuge deleted the doc-docker-setup branch January 12, 2023 09:52
v1v added a commit that referenced this pull request Jan 25, 2023
@v1v
Merge remote-tracking branch 'upstream/main' into feature/use-github-…
1469de7 
…actions

* upstream/main: (76 commits)
  Bump version.byte-buddy from 1.12.20 to 1.12.21 (#2953)
  Fix instrumentation for WebFlux with Spring 6.x (#2936)
  Fix SQS instrumentation within messaging transactions (#2979)
  Add test for unsampled Transaction (#2950)
  clarify about dropped requests for sampling in documentation (#2957)
  Doc add first stack trace detail (#2978)
  SpanBuilder.addLink is supported, so delete wrong comment (#2975)
  [doc] document log sending (#2929)
  Fix agent log sending (#2974)
  Bump version.aws.sdk from 2.19.8 to 2.19.18 in /apm-agent-plugins (#2973)
  test: synchronizing gherkin specs (#2965)
  Bump aws-java-sdk from 1.12.353 to 1.12.376 in /apm-agent-plugins (#2944)
  Fixed AgentOverheadMetricsTest flakyness (#2918)
  Fix AWS instrumentation destination.service.resource handling (#2947)
  [doc] restructure logs doc (#2916)
  Junit5 test with dependencies runner (#2962)
  Set service target for non-sampled ES client spans (#2959)
  Send logs via intake API (#2694)
  [doc] setup with docker image (#2956)
  Increase CI build timeout (#2955)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalkoren eyalkoren eyalkoren approved these changes

Assignees
No one assigned
Labels
agent-java docs Documentation
Projects
APM-Agents (OLD)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SylvainJuge @apmmachine @eyalkoren