Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Junit5 test with dependencies runner #2962

Merged

Conversation

JonasKunz
Copy link
Contributor

What does this PR do?

Adds a new TestClassWithDependenciesRunner variant which supports JUnit5 test classes.
Also did a bit of refactoring and moved the runner into the existing testutils package.

Checklist

@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) Jan 12, 2023
@JonasKunz JonasKunz marked this pull request as ready for review January 12, 2023 11:39
@github-actions
Copy link

/test

@apmmachine
Copy link
Collaborator

apmmachine commented Jan 12, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-16T14:19:58.287+0000

  • Duration: 68 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 3411
Skipped 44
Total 3455

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@SylvainJuge SylvainJuge mentioned this pull request Jan 12, 2023
38 tasks
Copy link
Member

@SylvainJuge SylvainJuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Good job! this unblocks the Junit5 migration that we aim to do for a while.

@JonasKunz
Copy link
Contributor Author

/test

@JonasKunz JonasKunz merged commit 79d39c7 into elastic:main Jan 16, 2023
APM-Agents (OLD) automation moved this from In Progress to Done Jan 16, 2023
@JonasKunz JonasKunz deleted the junit5-test-with-dependencies-runner branch January 16, 2023 15:43
v1v added a commit that referenced this pull request Jan 25, 2023
…actions

* upstream/main: (76 commits)
  Bump version.byte-buddy from 1.12.20 to 1.12.21 (#2953)
  Fix instrumentation for WebFlux with Spring 6.x (#2936)
  Fix SQS instrumentation within messaging transactions (#2979)
  Add test for unsampled Transaction (#2950)
  clarify about dropped requests for sampling in documentation (#2957)
  Doc add first stack trace detail (#2978)
  SpanBuilder.addLink is supported, so delete wrong comment (#2975)
  [doc] document log sending (#2929)
  Fix agent log sending (#2974)
  Bump version.aws.sdk from 2.19.8 to 2.19.18 in /apm-agent-plugins (#2973)
  test: synchronizing gherkin specs (#2965)
  Bump aws-java-sdk from 1.12.353 to 1.12.376 in /apm-agent-plugins (#2944)
  Fixed AgentOverheadMetricsTest flakyness (#2918)
  Fix AWS instrumentation destination.service.resource handling (#2947)
  [doc] restructure logs doc (#2916)
  Junit5 test with dependencies runner (#2962)
  Set service target for non-sampled ES client spans (#2959)
  Send logs via intake API (#2694)
  [doc] setup with docker image (#2956)
  Increase CI build timeout (#2955)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants