-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Junit5 test with dependencies runner #2962
Merged
JonasKunz
merged 8 commits into
elastic:main
from
JonasKunz:junit5-test-with-dependencies-runner
Jan 16, 2023
Merged
Junit5 test with dependencies runner #2962
JonasKunz
merged 8 commits into
elastic:main
from
JonasKunz:junit5-test-with-dependencies-runner
Jan 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/test |
38 tasks
SylvainJuge
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Good job! this unblocks the Junit5 migration that we aim to do for a while.
apm-agent-core/src/test/java/co/elastic/apm/agent/testutils/TestClassWithDependencyRunner.java
Show resolved
Hide resolved
/test |
v1v
added a commit
that referenced
this pull request
Jan 25, 2023
…actions * upstream/main: (76 commits) Bump version.byte-buddy from 1.12.20 to 1.12.21 (#2953) Fix instrumentation for WebFlux with Spring 6.x (#2936) Fix SQS instrumentation within messaging transactions (#2979) Add test for unsampled Transaction (#2950) clarify about dropped requests for sampling in documentation (#2957) Doc add first stack trace detail (#2978) SpanBuilder.addLink is supported, so delete wrong comment (#2975) [doc] document log sending (#2929) Fix agent log sending (#2974) Bump version.aws.sdk from 2.19.8 to 2.19.18 in /apm-agent-plugins (#2973) test: synchronizing gherkin specs (#2965) Bump aws-java-sdk from 1.12.353 to 1.12.376 in /apm-agent-plugins (#2944) Fixed AgentOverheadMetricsTest flakyness (#2918) Fix AWS instrumentation destination.service.resource handling (#2947) [doc] restructure logs doc (#2916) Junit5 test with dependencies runner (#2962) Set service target for non-sampled ES client spans (#2959) Send logs via intake API (#2694) [doc] setup with docker image (#2956) Increase CI build timeout (#2955) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new
TestClassWithDependenciesRunner
variant which supports JUnit5 test classes.Also did a bit of refactoring and moved the runner into the existing
testutils
package.Checklist
I have updated CHANGELOG.asciidoc