Apachehttpclient v5 #3419
Merged
Apachehttpclient v5 #3419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
agent-java
community
|
👋 @videnkz Thanks a lot for your contribution! It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it. Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it. |
…lientInstrumentationTest 5
JonasKunz
reviewed
Nov 30, 2023
...n/src/main/java/co/elastic/apm/agent/httpclient/v5/BaseApacheHttpClient5Instrumentation.java
Outdated
Show resolved
Hide resolved
...lugin/src/main/java/co/elastic/apm/agent/httpclient/v5/ApacheHttpClient5Instrumentation.java
Outdated
Show resolved
Hide resolved
...lugin/src/main/java/co/elastic/apm/agent/httpclient/v5/ApacheHttpClient5Instrumentation.java
Outdated
Show resolved
Hide resolved
.../src/main/java/co/elastic/apm/agent/httpclient/v5/ApacheHttpAsyncClient5Instrumentation.java
Outdated
Show resolved
Hide resolved
...rc/main/java/co/elastic/apm/agent/httpclient/common/AbstractApacheHttpAsyncClientAdvice.java
Outdated
Show resolved
Hide resolved
...gin/src/main/java/co/elastic/apm/agent/httpclient/v5/helper/ApacheHttpAsyncClientHelper.java
Outdated
Show resolved
Hide resolved
apm-agent-plugins/apm-apache-httpclient/apm-apache-httpclient-common/pom.xml
Outdated
Show resolved
Hide resolved
...ttemplate-plugin/src/test/java/co/elastic/apm/agent/resttemplate/FeignClientIntegration.java
Outdated
Show resolved
Hide resolved
...ttemplate-plugin/src/test/java/co/elastic/apm/agent/resttemplate/FeignClientIntegration.java
Outdated
Show resolved
Hide resolved
…syncRequestProducerWrapper in case when delegate is not null. Added tests that breaks behavior when asyncClientHelper.recycle(this); called multiple times when delegate is already null in ASyncRequestProductWrapper
JonasKunz
previously approved these changes
Dec 1, 2023
|
@elasticmachine run elasticsearch-ci/docs |
SylvainJuge
reviewed
Dec 4, 2023
...t5-plugin/src/main/java/co/elastic/apm/agent/httpclient/v5/helper/FutureCallbackWrapper.java
Outdated
Show resolved
Hide resolved
...t5-plugin/src/main/java/co/elastic/apm/agent/httpclient/v5/helper/FutureCallbackWrapper.java
Outdated
Show resolved
Hide resolved
...t5-plugin/src/main/java/co/elastic/apm/agent/httpclient/v5/helper/FutureCallbackWrapper.java
Outdated
Show resolved
Hide resolved
...c/test/java/co/elastic/apm/agent/httpclient/v5/ApacheHttpAsyncClientInstrumentationTest.java
Outdated
Show resolved
Hide resolved
...c/test/java/co/elastic/apm/agent/httpclient/v5/ApacheHttpAsyncClientInstrumentationTest.java
Outdated
Show resolved
Hide resolved
...c/test/java/co/elastic/apm/agent/httpclient/v5/ApacheHttpAsyncClientInstrumentationTest.java
Outdated
Show resolved
Hide resolved
SylvainJuge
approved these changes
Dec 5, 2023
JonasKunz
approved these changes
Dec 5, 2023
|
@elasticmachine run elasticsearch-ci/docs |
|
@elasticmachine run elasticsearch-ci/docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
finally closes #2954
Checklist
Added an API method or config option? Document in which version this will be introducedI have made corresponding changes to the documentationFeignClientrequests