Disabling Log correlation when agent is inactive #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eyalkoren
commented
Aug 8, 2019
•
eyalkoren
commented
- Implement code
- Add tests
- Update documentation
- Update CHANGELOG.md
|
What if active is set to false after the activation and before the deactivation? We should have a transaction-scoped flag (can we use the noop flag?) which is consistent for a whole transaction. If that is false, call no scope listeners. |
I only check in adding to MDC but always removing from MDC. |
felixbarny
reviewed
Aug 8, 2019
...pm-slf4j-plugin/src/test/java/co/elastic/apm/agent/slf4j/Slf4JMdcActivationListenerTest.java
Show resolved
Hide resolved
felixbarny
approved these changes
Aug 8, 2019
| @@ -5,6 +5,7 @@ | |||
| ## Bug Fixes | |||
| * A warning in logs saying APM server is not available when using 1.8 with APM server 6.x | |||
| * `ApacheHttpAsyncClientInstrumentation` matching increases startup time considerably | |||
| * Log correlation feature is active when `active==false` | |||
There was a problem hiding this comment.
Suggested change
| * Log correlation feature is active when `active==false` | |
| * Disable log correlation feature when `active=false` |
There was a problem hiding this comment.
The Bug Fixes section usually describes the bugs and not the fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.