Do not extract request remote address from headers #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #889 +/- ##
=========================================
Coverage 64.57% 64.57%
Complexity 1965 1965
=========================================
Files 232 232
Lines 9461 9461
Branches 1235 1235
=========================================
Hits 6109 6109
Misses 2964 2964
Partials 388 388Continue to review full report at Codecov.
|
|
Jenkins run the tests |
felixbarny
reviewed
Oct 21, 2019
| @@ -311,7 +311,7 @@ private void fillRequest(Request request, String protocol, String method, boolea | |||
|
|
|||
| request.getSocket() | |||
| .withEncrypted(secure) | |||
| .withRemoteAddress(ClientIpUtils.getRealIp(request.getHeaders(), remoteAddr)); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #886
Checklist