fix: remove zero count metrics from registry #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
agent-nodejs
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
astorm
commented
Jul 21, 2021
| @@ -144,7 +159,7 @@ test('does not include breakdown when not sampling', t => { | |||
|
|
|||
| const { metricsets } = data | |||
|
|
|||
| assertMetricSet(t, 'transaction', metricsets, { | |||
| assertMetricSet(t, 'transaction not sampling', metricsets, { | |||
There was a problem hiding this comment.
Previously this test asserted that transaction.breakdown.count was reported. However, with the new behavior the transaction.breakdown.count metric is no longer reported in this specific scenario because its count is zero.
|
jenkins run the tests please |
trentm
reviewed
Jul 21, 2021
CHANGELOG.asciidoc
Outdated
Comment on lines
42
to
43
| * The agent will no longer report couting metrics with a value of zero, and will | ||
| remove these metrics from the registry. |
There was a problem hiding this comment.
- s/couting/counting/
- Issue link please.
trentm
approved these changes
Jul 21, 2021
dgieselaar
pushed a commit
to dgieselaar/apm-agent-nodejs
that referenced
this pull request
Sep 10, 2021
* feat: no longer sends counting metrics with a count of zero and removes them from the metrics cache/registry Closes: elastic#1977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1977
Checklist