feat: support instrumenting mongodb@6 #3596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [mongodb](https://github.com/mongodb/node-mongodb-native) from 5.1.0 to 6.0.0. - [Release notes](https://github.com/mongodb/node-mongodb-native/releases) - [Changelog](https://github.com/mongodb/node-mongodb-native/blob/main/HISTORY.md) - [Commits](mongodb/node-mongodb-native@v5.1.0...v6.0.0) --- updated-dependencies: - dependency-name: mongodb dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
the
dependencies
github-actions
bot
added
the
agent-nodejs
|
new |
Actually I think it is from v15.0.0: The minor versions at node.green can be misleading, because the table doesn't necessarily show the particular minor version where something changed. The compatibility table on MDN often shows the specific node version: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing_assignment#browser_compatibility |
|
Thanks for pointing the right version @trentm. I'll change the version checking to |
|
Testing locally there is a hang in mongodb.test.js with this update: |
|
Ah, it hangs because our mongodb instr is explicitly doing nothing for mongodb@6 and mongodb.test.js is using the poor This fixes it, as a start: diff --git a/lib/instrumentation/modules/mongodb.js b/lib/instrumentation/modules/mongodb.js
index 81cd39db..bdaee49b 100644
--- a/lib/instrumentation/modules/mongodb.js
+++ b/lib/instrumentation/modules/mongodb.js
@@ -17,7 +17,7 @@ const HOSTNAME_PORT_RE = /^(.+):(\d+)$/;
module.exports = (mongodb, agent, { version, enabled }) => {
if (!enabled) return mongodb;
- if (!semver.satisfies(version, '>=3.3 <6.0')) {
+ if (!semver.satisfies(version, '>=3.3 <7.0'))This'll no longer be a "bump a dev dep" change, though. It'll be a "add support for mongodb@6". |
trentm
changed the title
trentm
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps mongodb from 5.1.0 to 6.0.0.
Release notes
Sourced from mongodb's releases.
... (truncated)
Changelog
Sourced from mongodb's changelog.
... (truncated)
Commits
e57b738chore(main): release 6.0.0 [skip-ci] (#3762)e70826adocs: generate docs from latest main [skip-ci] (#3744)df1b4f2docs(NODE-5560): add v6 upgrade guide (#3844)7bef363feat(NODE-5584)!: adopt bson v6 and mongodb-client-encryption v6 (#3845)05d2725fix(NODE-5592): withTransaction return type (#3846)91152b9chore(NODE-5581): pull in bson alpha.1 and mongodb-legacy main (#3843)ecb2e20chore: fix alpha version guardea2d60arefactor(NODE-5514): make FLE logic use async-await (#3830)a17b0affeat(NODE-5484)!: mark MongoError for internal use and remove Node14 cause as...33c86c9feat(NODE-5566): add ability to provide CRL file via tlsCRLFile (#3834)Maintainer changes
This version was pushed to npm by dbx-node, a new releaser for mongodb since your current version.
Most Recent Ignore Conditions Applied to This Pull Request
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Note: Dependabot was ignoring updates to this dependency, but since you've updated it yourself we've started tracking it for you again. 🤖
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.