feat: improved filtering function API #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qard
approved these changes
Sep 12, 2018
|
LGTM other than failing tests. Seems to be because the abort tests expect no connection to be made, but should it not be that a connection is made, but no data is sent? |
|
I'll rebase once #580 is merged which fixes the tests |
watson
force-pushed
the
filters
branch
3 times, most recently
from
69d382c
to
efb7749
Compare
Changes the `agent.addFilter()` function to be called once per event instead of with an array of events. Besides the existing filtering function, three new custom filtering functions have been added: - `agent.addErrorFilter()` - `agent.addTransactionFilter()` - `agent.addSpanFilter()` BREAKING CHANGE: The `agent.addFilter()` API have changed.
watson
added a commit
that referenced
this pull request
Sep 13, 2018
Changes the `agent.addFilter()` function to be called once per event instead of with an array of events. Besides the existing filtering function, three new custom filtering functions have been added: - `agent.addErrorFilter()` - `agent.addTransactionFilter()` - `agent.addSpanFilter()` BREAKING CHANGE: The `agent.addFilter()` API have changed.
watson
added a commit
that referenced
this pull request
Oct 19, 2018
Changes the `agent.addFilter()` function to be called once per event instead of with an array of events. Besides the existing filtering function, three new custom filtering functions have been added: - `agent.addErrorFilter()` - `agent.addTransactionFilter()` - `agent.addSpanFilter()` BREAKING CHANGE: The `agent.addFilter()` API have changed.
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Oct 27, 2018
Changes the `agent.addFilter()` function to be called once per event instead of with an array of events. Besides the existing filtering function, three new custom filtering functions have been added: - `agent.addErrorFilter()` - `agent.addTransactionFilter()` - `agent.addSpanFilter()` BREAKING CHANGE: The `agent.addFilter()` API have changed.
Qard
pushed a commit
that referenced
this pull request
Oct 31, 2018
Changes the `agent.addFilter()` function to be called once per event instead of with an array of events. Besides the existing filtering function, three new custom filtering functions have been added: - `agent.addErrorFilter()` - `agent.addTransactionFilter()` - `agent.addSpanFilter()` BREAKING CHANGE: The `agent.addFilter()` API have changed.
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Nov 6, 2018
Changes the `agent.addFilter()` function to be called once per event instead of with an array of events. Besides the existing filtering function, three new custom filtering functions have been added: - `agent.addErrorFilter()` - `agent.addTransactionFilter()` - `agent.addSpanFilter()` BREAKING CHANGE: The `agent.addFilter()` API have changed.
watson
added a commit
that referenced
this pull request
Nov 6, 2018
Changes the `agent.addFilter()` function to be called once per event instead of with an array of events. Besides the existing filtering function, three new custom filtering functions have been added: - `agent.addErrorFilter()` - `agent.addTransactionFilter()` - `agent.addSpanFilter()` BREAKING CHANGE: The `agent.addFilter()` API have changed.
Qard
pushed a commit
that referenced
this pull request
Nov 8, 2018
Changes the `agent.addFilter()` function to be called once per event instead of with an array of events. Besides the existing filtering function, three new custom filtering functions have been added: - `agent.addErrorFilter()` - `agent.addTransactionFilter()` - `agent.addSpanFilter()` BREAKING CHANGE: The `agent.addFilter()` API have changed.
watson
added a commit
that referenced
this pull request
Nov 10, 2018
Changes the `agent.addFilter()` function to be called once per event instead of with an array of events. Besides the existing filtering function, three new custom filtering functions have been added: - `agent.addErrorFilter()` - `agent.addTransactionFilter()` - `agent.addSpanFilter()` BREAKING CHANGE: The `agent.addFilter()` API have changed.
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Nov 13, 2018
Changes the `agent.addFilter()` function to be called once per event instead of with an array of events. Besides the existing filtering function, three new custom filtering functions have been added: - `agent.addErrorFilter()` - `agent.addTransactionFilter()` - `agent.addSpanFilter()` BREAKING CHANGE: The `agent.addFilter()` API have changed.
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Nov 13, 2018
Changes the `agent.addFilter()` function to be called once per event instead of with an array of events. Besides the existing filtering function, three new custom filtering functions have been added: - `agent.addErrorFilter()` - `agent.addTransactionFilter()` - `agent.addSpanFilter()` BREAKING CHANGE: The `agent.addFilter()` API have changed.
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Nov 13, 2018
Changes the `agent.addFilter()` function to be called once per event instead of with an array of events. Besides the existing filtering function, three new custom filtering functions have been added: - `agent.addErrorFilter()` - `agent.addTransactionFilter()` - `agent.addSpanFilter()` BREAKING CHANGE: The `agent.addFilter()` API have changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
agent.addFilter()function to be called once per eventinstead of with an array of events.
Besides the existing filtering function, three new custom filtering
functions have been added:
agent.addErrorFilter()agent.addTransactionFilter()agent.addSpanFilter()BREAKING CHANGE: The
agent.addFilter()API have changed.Checklist