Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

security: add permissions block to workflows #1136

Merged
merged 5 commits into from Apr 3, 2024
Merged

security: add permissions block to workflows #1136

merged 5 commits into from Apr 3, 2024

Conversation

reakaleek
Copy link
Member

Details

⚠️ This PR was created by an automated tool. Please review the changes carefully. ⚠️

We want to set the default permissions for workflows to read-only for contents.
This is a security measure to prevent accidental changes to the repository.

This change adds a top-level permissions block to all workflows in the .github/workflows directory.

permissions:
  contents: read

In some cases workflows might need more permissions than just contents: read.
Please checkout this branch and add the necessary permissions to the workflows.

If your workflow uses a Personal Access Token (PAT), we can still add the permissions block,
but it will not have any effect.

Merging this PR as is might cause workflows that need more permissions to fail.

If there are any questions, please reach out to the @elastic/observablt-ci

@reakaleek reakaleek self-assigned this Feb 17, 2024
@reakaleek reakaleek requested a review from a team February 17, 2024 18:59
@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) Feb 17, 2024
v1v
v1v reviewed Mar 12, 2024
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/test-packages.yml Outdated Show resolved Hide resolved
@v1v
Copy link
Member

v1v commented Mar 27, 2024

Blocked by #1144

@reakaleek reakaleek merged commit ccd4cfa into main Apr 3, 2024
168 checks passed
APM-Agents (OLD) automation moved this from In Progress to Done Apr 3, 2024
@reakaleek reakaleek deleted the gh-oblt/add-permission-block-to-workflows branch April 3, 2024 12:00
v1v added a commit that referenced this pull request Apr 26, 2024
@v1v
Merge remote-tracking branch 'upstream/main' into feature/provenance
f46383d 
* upstream/main:
  feat: use pre-built fpm container image (#1145)
  ci(fix): use docker compose v2 instead of v1 (#1146)
  security: add permissions block to workflows (#1136)
  fix: use latest fpm version (#1144)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v1v v1v v1v approved these changes

Assignees

@reakaleek reakaleek

Labels
agent-php
Projects
APM-Agents (OLD)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reakaleek @v1v