Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use latest fpm version #1144

Merged
merged 1 commit into from Mar 29, 2024
Merged

fix: use latest fpm version #1144

merged 1 commit into from Mar 29, 2024

Conversation

amannocci
Copy link
Contributor

@amannocci amannocci commented Mar 26, 2024 •
edited

What is the change being made?

  • Update fpm container image to use ruby 3.3.x.

Why is the change being made?

  • The container image is using ruby 2.7.x which is EOL.
  • The build of this container image has been broken for a while.

@amannocci
fix: use latest fpm version
1d3b353 
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) Mar 26, 2024
@amannocci amannocci requested a review from a team March 26, 2024 16:59
@amannocci amannocci self-assigned this Mar 26, 2024
@v1v v1v mentioned this pull request Mar 27, 2024
Merged
@intuibase intuibase self-requested a review March 27, 2024 11:27
@amannocci amannocci marked this pull request as ready for review March 27, 2024 13:46
v1v
v1v approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, the release workflow uses the same steps in test.

If that's the case, I think we are good to move this forward. Thanks Adrien!

@amannocci amannocci merged commit 1469804 into main Mar 29, 2024
171 checks passed
APM-Agents (OLD) automation moved this from In Progress to Done Mar 29, 2024
@amannocci amannocci deleted the fix/build-packages branch March 29, 2024 10:01
v1v added a commit that referenced this pull request Apr 26, 2024
@v1v
Merge remote-tracking branch 'upstream/main' into feature/provenance
f46383d 
* upstream/main:
  feat: use pre-built fpm container image (#1145)
  ci(fix): use docker compose v2 instead of v1 (#1146)
  security: add permissions block to workflows (#1136)
  fix: use latest fpm version (#1144)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v1v v1v v1v approved these changes

@intuibase intuibase intuibase approved these changes

@reakaleek reakaleek reakaleek approved these changes

Assignees

@amannocci amannocci

Labels
agent-php
Projects
APM-Agents (OLD)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amannocci @v1v @intuibase @reakaleek