Add Redis pub/sub instrumentation #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
|
@Sparkycz great work, thanks a lot for all your PRs! |
| @@ -38,7 +38,8 @@ | |||
| class RedisConnectionPoolInstrumentation(AbstractInstrumentedModule): | |||
| name = "aioredis" | |||
|
|
|||
| instrument_list = [("aioredis.pool", "ConnectionsPool.execute")] | |||
| instrument_list = [("aioredis.pool", "ConnectionsPool.execute"), | |||
| ("aioredis.pool", "ConnectionsPool.execute_pubsub")] | |||
|
|
|||
| def call(self, module, method, wrapped, instance, args, kwargs): | |||
There was a problem hiding this comment.
why is this function not marked as async? @beniwohli
| @@ -73,7 +74,8 @@ def call(self, module, method, wrapped, instance, args, kwargs): | |||
| class RedisConnectionInstrumentation(AbstractInstrumentedModule): | |||
| name = "aioredis" | |||
|
|
|||
| instrument_list = (("aioredis.connection", "RedisConnection.execute"),) | |||
| instrument_list = (("aioredis.connection", "RedisConnection.execute"), | |||
| ("aioredis.pool", "ConnectionsPool.execute_pubsub")) | |||
|
|
|||
| def call(self, module, method, wrapped, instance, args, kwargs): | |||
| span = execution_context.get_span() | |||
There was a problem hiding this comment.
this is missing async_capture_span call hence it would not create a span in APM. Also, I think this should also be async and return needs to have await with it @beniwohli @Sparkycz
beniwohli
added a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
* Add instrumentation of redis pub/sub commands * Add instrumentation of aioredis pub/sub commands Co-authored-by: Benjamin Wohlwend <beni@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #828