Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

label no longer fails when called without a client #1596

Merged
merged 1 commit into from
Jul 25, 2022
Merged

label no longer fails when called without a client #1596

merged 1 commit into from
Jul 25, 2022

Conversation

dennis-wey
Copy link
Contributor

What does this pull request do?

elasticapm.label(. . .)no longer fails when no client is present

Related issues

closes #1595

@github-actions github-actions bot added agent-python community Issues opened by the community triage Issues awaiting triage labels Jul 25, 2022
@apmmachine
Copy link
Contributor

apmmachine commented Jul 25, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-25T20:05:37.104+0000

  • Duration: 28 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 4927
Skipped 3455
Total 8382

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

beniwohli
beniwohli approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@beniwohli beniwohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks @dennis-wey !

@apmmachine
Copy link
Contributor

apmmachine commented Jul 25, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (68/68) 💚
Files 100.0% (227/227) 💚
Classes 100.0% (227/227) 💚
Lines 89.643% (17258/19252) 👍 0.002
Conditionals 76.869% (3147/4094) 👍

@basepi
Copy link
Contributor

basepi commented Jul 25, 2022

/test linters

@basepi basepi enabled auto-merge (squash) July 25, 2022 20:12
@basepi basepi merged commit f8c18a1 into elastic:main Jul 25, 2022
@dennis-wey
Copy link
Contributor Author

@basepi @beniwohli thanks for reviewing and merging this so quickly! Would it be possible to create a bugfix release with the current changes on master?

@basepi
Copy link
Contributor

basepi commented Aug 3, 2022

Yes I'll create a bugfix release, probably tomorrow.

@basepi
Copy link
Contributor

basepi commented Aug 4, 2022

Version 6.10.2 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beniwohli beniwohli beniwohli approved these changes

@basepi basepi basepi approved these changes

Assignees
No one assigned
Labels
agent-python community Issues opened by the community triage Issues awaiting triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

elasticapm.label fails when trying to warn that no transaction is present
4 participants
@dennis-wey @apmmachine @basepi @beniwohli