Fix extract_signature when sql is a bytes object #366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
beniwohli
suggested changes
Dec 21, 2018
There was a problem hiding this comment.
Great catch, thanks @ellisvalentiner! I left just a little suggestion up top!
|
Thanks for the fix @ellisvalentiner, it's now merged to master (after cleaning up a test that now failed), and I will push a release later today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In psycopg2's
execute_batchandexecute_valuesfunctions, the SQL statement is a bytes object and not a string (see psycopg2's extras.py#L1198). This may also be a problem for other database adapters but I'm only aware of this behavior with psycopg2.extract_signatureraises a TypeError when thesqlparameter is a bytes object becausesql.find(" ")expects a bytes object and" "is a string.My proposed solution is to check whether
sqlis a bytes object and decode if necessary.I have signed the CLA.