Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-json-specs.yml: add container_metadata_discovery.json #1404

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

v1v
Copy link
Member

@v1v v1v commented Aug 10, 2023

What does this pull request do?

Update the updatecli pipeline for the automation regarding the json specs.

Why is it important?

container_metadata_discovery.json is a new file while cgroup_parsing.json has been removed.

Otherwise the automation fails

https://github.com/elastic/apm-agent-ruby/actions/runs/5817528861/job/15772319674#step:3:2142

image

Checklist

  • I have signed the Contributor License Agreement.
  • My code follows the style guidelines of this project (See .rubocop.yml)
  • I have rebased my changes on top of the latest main branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Related issues

@v1v v1v requested review from estolfo and a team August 10, 2023 06:25
@v1v v1v self-assigned this Aug 10, 2023
@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) Aug 10, 2023
@v1v v1v merged commit 2212536 into elastic:main Aug 15, 2023
55 checks passed
APM-Agents (OLD) automation moved this from In Progress to Done Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants