Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Central Config: Once more for Jenkins #484

Merged
merged 3 commits into from Aug 16, 2019
Merged

Central Config: Once more for Jenkins #484

merged 3 commits into from Aug 16, 2019

Conversation

mikker
Copy link
Contributor

@mikker mikker commented Aug 15, 2019 •
edited by zube bot

Same as #464 but on new branch

This was referenced Aug 15, 2019
Closed
Closed
@mikker mikker requested a review from estolfo August 15, 2019 14:07
estolfo
estolfo approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@estolfo estolfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I just made some minor comments.

docs/configuration.asciidoc Show resolved Hide resolved
lib/elastic_apm/central_config.rb Show resolved Hide resolved
lib/elastic_apm/central_config.rb Show resolved Hide resolved
@mikker mikker merged commit 69ce5d0 into elastic:master Aug 16, 2019
@mikker mikker deleted the central-config-mega-config branch October 9, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estolfo estolfo estolfo approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikker @estolfo