Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new SQL parser as default #730

Merged
merged 2 commits into from Mar 4, 2020
Merged

Use the new SQL parser as default #730

merged 2 commits into from Mar 4, 2020

Conversation

mikker
Copy link
Contributor

@mikker mikker commented Mar 4, 2020

This PR switches the default SQL parser to the new one.

The old one is still provided so users can easily switch if they encounter any problems.

In a few months we'll remove the old approach completely.

@mikker mikker added this to the 7.7 milestone Mar 4, 2020
@mikker mikker self-assigned this Mar 4, 2020
@codecov-io
Copy link

codecov-io commented Mar 4, 2020

Codecov Report

Merging #730 into master will decrease coverage by 2.52%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #730      +/-   ##
==========================================
- Coverage   64.35%   61.83%   -2.53%     
==========================================
  Files         103      105       +2     
  Lines        3100     3322     +222     
==========================================
+ Hits         1995     2054      +59     
- Misses       1105     1268     +163
Impacted Files Coverage Δ
lib/elastic_apm/sql.rb 77.77% <100%> (ø) ⬆️
lib/elastic_apm/config.rb 78.82% <50%> (-0.82%) ⬇️
lib/elastic_apm/sql_summarizer.rb
lib/elastic_apm/sql/signature.rb 20.54% <0%> (ø)
lib/elastic_apm/sql/tokenizer.rb 18.18% <0%> (ø)
lib/elastic_apm/sql/tokens.rb 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b5728...3e4eb6e. Read the comment docs.

Copy link
Contributor

@estolfo estolfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mikker mikker merged commit 2e0ab28 into elastic:master Mar 4, 2020
@mikker mikker deleted the sql-parser branch March 4, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants