Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues with running test suite on ruby 3.0:
google-protobuf
cannot be install on ruby >= 2.8. The message isgoogle-protobuf-3.14.0-universal-darwin requires ruby version < 2.8.dev, >= 2.3, which is incompatible with the current version, ruby 3.0.0p0
The json validation spec is failing because the
json-schema
gem needs to update their use ofKernel#open
to beURI.open
instead here. Reference here. I've opened an issue with their repo here.After this is merged, open an issue as a reminder to:
json-schema
version is released supporting ruby 3.0, possibly change thejson_schema_matcher
to pass a url toJSON::Valdiator.validate!
again