Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ruby 3.0 on Jenkins #925

Merged
merged 4 commits into from
Jan 13, 2021
Merged

Test ruby 3.0 on Jenkins #925

merged 4 commits into from
Jan 13, 2021

Conversation

estolfo
Copy link
Contributor

@estolfo estolfo commented Jan 13, 2021

Issues with running test suite on ruby 3.0:

  • google-protobuf cannot be install on ruby >= 2.8. The message is google-protobuf-3.14.0-universal-darwin requires ruby version < 2.8.dev, >= 2.3, which is incompatible with the current version, ruby 3.0.0p0

  • The json validation spec is failing because the json-schema gem needs to update their use of Kernel#open to be URI.open instead here. Reference here. I've opened an issue with their repo here.

After this is merged, open an issue as a reminder to:

  • When a grape version supporting ruby 3.0 is released, update the jenkins matrices to include that version
  • When a json-schema version is released supporting ruby 3.0, possibly change the json_schema_matcher to pass a url to JSON::Valdiator.validate! again

@apmmachine
Copy link
Collaborator

apmmachine commented Jan 13, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Started by user Emily S

  • Start Time: 2021-01-13T10:49:33.026+0000

  • Duration: 20 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 51264
Skipped 93
Total 51357

Steps errors 1

Expand to view the steps failures

Shell Script
  • Took 2 min 27 sec . View more details on here
  • Description: [2021-01-13T10:57:03.467Z] + ./spec/scripts/spec.sh docker.elastic.co/observability-ci/jruby:9.2-11-

@mikker
Copy link
Contributor

mikker commented Jan 13, 2021

🍏 📗 🟢 💚 🥗

@estolfo estolfo merged commit 00fb70c into elastic:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants