Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(rum-core): refactor error-logging & stack service to improve bundlesize #233

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

vigneshshanmugam
Copy link
Member

@vigneshshanmugam vigneshshanmugam commented Mar 28, 2019

  • Part of Optimize bundle size #159 Effort.
  • Switched stackservice from class to functions for reducing bundle size and importing only required functions

@vigneshshanmugam vigneshshanmugam changed the title perf(rum-core): refactor stack service and remove unused code perf(rum-core): refactor transaction & stack service to improve bundlesize Mar 28, 2019
@vigneshshanmugam vigneshshanmugam self-assigned this Mar 28, 2019
Copy link
Contributor

@hmdhk hmdhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments!

packages/rum-core/src/error-logging/stack-trace.js Outdated Show resolved Hide resolved
@vigneshshanmugam vigneshshanmugam force-pushed the unused-code branch 2 times, most recently from 312ad3f to 46b37f9 Compare April 9, 2019 08:51
@elastic elastic deleted a comment from hmdhk Jun 3, 2019
@elastic elastic deleted a comment from hmdhk Jun 3, 2019
@vigneshshanmugam vigneshshanmugam changed the title perf(rum-core): refactor transaction & stack service to improve bundlesize perf(rum-core): refactor error-logging & stack service to improve bundlesize Jun 3, 2019
Copy link
Contributor

@hmdhk hmdhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge once the tests are green!

@vigneshshanmugam vigneshshanmugam merged commit f2b2562 into elastic:master Jun 4, 2019
@vigneshshanmugam vigneshshanmugam deleted the unused-code branch June 4, 2019 06:46
David-Development pushed a commit to David-Development/apm-agent-rum-js that referenced this pull request Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants