Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable cgo #292

Merged
merged 2 commits into from
Aug 26, 2022
Merged

feat: disable cgo #292

merged 2 commits into from
Aug 26, 2022

Conversation

kruskall
Copy link
Member

build the extension with cgo disabled, to ensure there are
no glibc/ABI compatibility issues between the build host and
the target Lambda execution environment.

Closes #290

build the extension with cgo disabled, to ensure there are
no glibc/ABI compatibility issues between the build host and
the target Lambda execution environment.
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Aug 25, 2022
@apmmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-25T12:45:22.997+0000

  • Duration: 8 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 160
Skipped 2
Total 162

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@kruskall kruskall merged commit 7aa599e into elastic:main Aug 26, 2022
@kruskall kruskall deleted the feat/disable-cgo branch August 26, 2022 07:51
@felixbarny
Copy link
Member

Did this have an impact on the size of the binary? If so, what's the before and after? Thanks!

@axw
Copy link
Member

axw commented Aug 26, 2022

There's a small reduction in size.

Before:

-rwxrwxr-x 1 andrew andrew  11M Aug 24 17:01 bin/extensions/apm-lambda-extension
-rw-rw-r-- 1 andrew andrew 5.5M Aug 26 17:40 bin/extension.zip

After:

-rwxrwxr-x 1 andrew andrew  10M Aug 26 07:51 bin/extensions/apm-lambda-extension
-rw-rw-r-- 1 andrew andrew 5.4M Aug 26 17:40 bin/extension.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-λ-extension AWS Lambda Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable cgo
4 participants