Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.7] action: lint is mandatory but doc changes don't need it (#10564) #10572

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

bmorelli25
Copy link
Member

Backport

This will backport the following commits from main to 8.7:

Questions ?

Please refer to the Backport tool documentation

@apmmachine
Copy link
Collaborator

apmmachine commented Mar 30, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-30T16:08:14.670+0000

  • Duration: 6 min 28 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate and publish the docker images.

  • /test windows : Build & tests on Windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Collaborator

📚 Go benchmark report

Diff with the 8.7 branch

goos: linux
goarch: amd64
pkg: github.com/elastic/apm-server/internal/agentcfg
cpu: 12th Gen Intel(R) Core(TM) i5-12500
                                  │ build/8.7/bench.out │             bench.out              │
                                  │       sec/op        │    sec/op     vs base              │
geomean                                    62.47n         62.23n        -0.39%
¹ need >= 6 samples for confidence interval at level 0.95

                                  │ build/8.7/bench.out │              bench.out              │
                                  │        B/op         │    B/op      vs base                │
geomean                                               ³                +0.00%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

                                  │ build/8.7/bench.out │              bench.out              │
                                  │      allocs/op      │  allocs/op   vs base                │
geomean                                               ³                +0.00%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

pkg: github.com/elastic/apm-server/internal/beater/request
                                             │ build/8.7/bench.out │             bench.out              │
                                             │       sec/op        │    sec/op     vs base              │
geomean                                               982.0n         934.9n        -4.79%
¹ need >= 6 samples for confidence interval at level 0.95

                                             │ build/8.7/bench.out │               bench.out               │
                                             │        B/op         │     B/op       vs base                │
geomean                                                          ³                  +0.00%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

                                             │ build/8.7/bench.out │              bench.out              │
                                             │      allocs/op      │  allocs/op   vs base                │
geomean                                                          ³                +0.00%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

pkg: github.com/elastic/apm-server/internal/publish
             │ build/8.7/bench.out │          bench.out           │
             │       sec/op        │   sec/op     vs base         │
¹ need >= 6 samples for confidence interval at level 0.95

             │ build/8.7/bench.out │           bench.out            │
             │        B/op         │     B/op       vs base         │
¹ need >= 6 samples for confidence interval at level 0.95

             │ build/8.7/bench.out │           bench.out           │
             │      allocs/op      │  allocs/op    vs base         │
¹ need >= 6 samples for confidence interval at level 0.95

pkg: github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics
                 │ build/8.7/bench.out │           bench.out           │
                 │       sec/op        │    sec/op     vs base         │
¹ need >= 6 samples for confidence interval at level 0.95

                 │ build/8.7/bench.out │            bench.out             │
                 │        B/op         │     B/op       vs base           │
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal

                 │ build/8.7/bench.out │           bench.out            │
                 │      allocs/op      │  allocs/op   vs base           │
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal

pkg: github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics
                        │ build/8.7/bench.out │           bench.out           │
                        │       sec/op        │    sec/op     vs base         │
¹ need >= 6 samples for confidence interval at level 0.95

                        │ build/8.7/bench.out │           bench.out            │
                        │        B/op         │    B/op      vs base           │
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal

                        │ build/8.7/bench.out │           bench.out            │
                        │      allocs/op      │  allocs/op   vs base           │
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal

pkg: github.com/elastic/apm-server/x-pack/apm-server/sampling
               │ build/8.7/bench.out │             bench.out              │
               │       sec/op        │    sec/op     vs base              │
geomean                 591.9n         613.6n        +3.67%
¹ need >= 6 samples for confidence interval at level 0.95

               │ build/8.7/bench.out │               bench.out               │
               │        B/op         │     B/op       vs base                │
geomean                            ³                  +0.28%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

               │ build/8.7/bench.out │              bench.out              │
               │      allocs/op      │  allocs/op   vs base                │
geomean                            ³                +0.00%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

pkg: github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage
                                            │ build/8.7/bench.out │              bench.out              │
                                            │       sec/op        │    sec/op     vs base               │
WriteTransaction/json_codec-12                       4.372µ ± ∞ ¹   4.084µ ± ∞ ¹   -6.59% (p=0.032 n=5)
ReadEvents/nop_codec_big_tx/10_events-12             33.19µ ± ∞ ¹   21.27µ ± ∞ ¹  -35.91% (p=0.016 n=5)
geomean                                              29.35µ         29.06µ         -1.01%
¹ need >= 6 samples for confidence interval at level 0.95

                                            │ build/8.7/bench.out │               bench.out                │
                                            │        B/op         │      B/op       vs base                │
ReadEvents/nop_codec_big_tx/10_events-12            25.11Ki ± ∞ ¹    25.13Ki ± ∞ ¹  +0.09% (p=0.032 n=5)
ReadEvents/nop_codec_big_tx/1000_events-12          2.091Mi ± ∞ ¹    2.078Mi ± ∞ ¹  -0.65% (p=0.024 n=5)
geomean                                             31.34Ki          31.34Ki        -0.01%
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal

                                            │ build/8.7/bench.out │              bench.out               │
                                            │      allocs/op      │  allocs/op    vs base                │
geomean                                               144.7          144.7        +0.00%
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal

report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat

@bmorelli25 bmorelli25 merged commit 3f0aa91 into elastic:8.7 Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants