Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: lint is mandatory but doc changes don't need it #10564

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

v1v
Copy link
Member

@v1v v1v commented Mar 30, 2023

Motivation/summary

lint check is mandatory regardless of the changes, so ci-docs.yml is workaround to skip checks when the CI does. not run for docs changes.

Otherwise, it might mislead contributors since the lint check will not allow merging docs only PRs.

cc @bmorelli25

@v1v v1v requested review from a team March 30, 2023 06:31
@v1v v1v self-assigned this Mar 30, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2023

This pull request does not have a backport label. Could you fix it @v1v? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.x is the label to automatically backport to the 7.x branch.
  • backport-7./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Mar 30, 2023
@apmmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-30T06:31:44.333+0000

  • Duration: 6 min 43 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate and publish the docker images.

  • /test windows : Build & tests on Windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Contributor

📚 Go benchmark report

Diff with the main branch

goos: linux
goarch: amd64
pkg: github.com/elastic/apm-server/internal/agentcfg
cpu: 12th Gen Intel(R) Core(TM) i5-12500
                                  │ build/main/bench.out │              bench.out              │
                                  │        sec/op        │    sec/op     vs base               │
FetchAndAdd/FetchFromCache-12                41.14n ± 1%    46.11n ± 0%  +12.08% (p=0.002 n=6)
FetchAndAdd/FetchAndAddToCache-12            96.74n ± 4%   104.40n ± 1%   +7.92% (p=0.002 n=6)
geomean                                      63.09n         69.38n        +9.98%

                                  │ build/main/bench.out │             bench.out              │
                                  │         B/op         │    B/op     vs base                │
geomean                                                ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                  │ build/main/bench.out │             bench.out              │
                                  │      allocs/op       │ allocs/op   vs base                │
geomean                                                ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

pkg: github.com/elastic/apm-server/internal/beater/request
                                             │ build/main/bench.out │              bench.out              │
                                             │        sec/op        │    sec/op     vs base               │
ContextReset/X-Real-IP_ipv6-12                         711.8n ± 36%   914.8n ± 17%  +28.52% (p=0.015 n=6)
ContextResetContentEncoding/empty-12                   122.2n ±  1%   136.2n ±  1%  +11.45% (p=0.002 n=6)
ContextResetContentEncoding/uncompressed-12            146.4n ±  1%   164.4n ±  1%  +12.30% (p=0.002 n=6)
ContextResetContentEncoding/deflate-12                 4.002µ ±  8%   3.628µ ±  7%   -9.33% (p=0.004 n=6)
geomean                                                936.9n         924.1n         -1.36%

                                             │ build/main/bench.out │              bench.out               │
                                             │         B/op         │     B/op      vs base                │
geomean                                                           ²                 +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                             │ build/main/bench.out │             bench.out              │
                                             │      allocs/op       │ allocs/op   vs base                │
geomean                                                           ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

pkg: github.com/elastic/apm-server/internal/publish
             │ build/main/bench.out │          bench.out          │
             │        sec/op        │   sec/op    vs base         │

             │ build/main/bench.out │           bench.out            │
             │         B/op         │     B/op       vs base         │

             │ build/main/bench.out │           bench.out           │
             │      allocs/op       │  allocs/op    vs base         │

pkg: github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics
                 │ build/main/bench.out │           bench.out           │
                 │        sec/op        │    sec/op     vs base         │

                 │ build/main/bench.out │            bench.out            │
                 │         B/op         │     B/op      vs base           │
¹ all samples are equal

                 │ build/main/bench.out │           bench.out           │
                 │      allocs/op       │ allocs/op   vs base           │
¹ all samples are equal

pkg: github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics
                        │ build/main/bench.out │             bench.out             │
                        │        sec/op        │   sec/op     vs base              │
AggregateTransaction-12            89.74n ± 3%   88.17n ± 1%  -1.75% (p=0.002 n=6)

                        │ build/main/bench.out │           bench.out           │
                        │         B/op         │    B/op     vs base           │
¹ all samples are equal

                        │ build/main/bench.out │           bench.out           │
                        │      allocs/op       │ allocs/op   vs base           │
¹ all samples are equal

pkg: github.com/elastic/apm-server/x-pack/apm-server/sampling
               │ build/main/bench.out │             bench.out              │
               │        sec/op        │    sec/op     vs base              │
geomean                  588.6n         609.1n        +3.48%

               │ build/main/bench.out │              bench.out               │
               │         B/op         │     B/op      vs base                │
geomean                             ²                 +0.23%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

               │ build/main/bench.out │             bench.out              │
               │      allocs/op       │ allocs/op   vs base                │
geomean                             ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

pkg: github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage
                                            │ build/main/bench.out │               bench.out               │
                                            │        sec/op        │    sec/op      vs base                │
WriteTransaction/json_codec-12                       4.276µ ±  22%   10.692µ ± 70%  +150.08% (p=0.004 n=6)
WriteTransaction/json_codec_big_tx-12                4.843µ ±   8%   11.121µ ± 25%  +129.65% (p=0.002 n=6)
ReadEvents/json_codec/0_events-12                    313.5n ±   6%    356.5n ± 11%   +13.75% (p=0.002 n=6)
ReadEvents/json_codec/1_events-12                    10.34µ ±   5%    10.88µ ±  6%    +5.26% (p=0.026 n=6)
ReadEvents/json_codec_big_tx/0_events-12             313.2n ±   7%    347.4n ±  6%   +10.90% (p=0.002 n=6)
ReadEvents/json_codec_big_tx/1_events-12             11.98µ ±   5%    12.80µ ±  5%    +6.85% (p=0.026 n=6)
ReadEvents/nop_codec/0_events-12                     320.9n ±   5%    356.2n ±  7%   +11.03% (p=0.004 n=6)
ReadEvents/nop_codec_big_tx/0_events-12              298.5n ±   5%    346.8n ±  6%   +16.20% (p=0.002 n=6)
IsTraceSampled/sampled-12                            68.46n ±   4%    77.26n ±  5%   +12.87% (p=0.002 n=6)
IsTraceSampled/unsampled-12                          71.02n ±   1%    78.45n ±  2%   +10.45% (p=0.002 n=6)
IsTraceSampled/unknown-12                            367.0n ±   2%    415.2n ±  2%   +13.16% (p=0.002 n=6)
geomean                                              28.79µ           31.28µ          +8.67%

                                            │ build/main/bench.out │               bench.out                │
                                            │         B/op         │      B/op       vs base                │
WriteTransaction/json_codec_big_tx-12               3.686Ki ±   0%    3.688Ki ±  0%  +0.05% (p=0.004 n=6)
ReadEvents/json_codec_big_tx/100_events-12         1007.2Ki ±   0%   1007.2Ki ±  0%  -0.00% (p=0.043 n=6)
geomean                                             31.37Ki           31.41Ki        +0.11%
¹ all samples are equal

                                            │ build/main/bench.out │              bench.out              │
                                            │      allocs/op       │  allocs/op   vs base                │
geomean                                                 144.7         144.7       -0.00%
¹ all samples are equal

report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat

@v1v v1v merged commit d362412 into elastic:main Mar 30, 2023
@bmorelli25
Copy link
Member

Is it cool if I backport this change to 8.7 as well? I'm seeing the same problem in that branch.

@kruskall
Copy link
Member

@Mergifyio backport 8.7

@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2023

backport 8.7

✅ Backports have been created

@bmorelli25
Copy link
Member

💚 All backports created successfully

Status Branch Result
8.7

Questions ?

Please refer to the Backport tool documentation

bmorelli25 pushed a commit to bmorelli25/apm-server that referenced this pull request Mar 30, 2023
bmorelli25 added a commit to bmorelli25/apm-server that referenced this pull request Mar 30, 2023
bmorelli25 added a commit that referenced this pull request Mar 30, 2023
kyungeunni pushed a commit to kyungeunni/apm-server that referenced this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants