-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
action: lint is mandatory but doc changes don't need it #10564
Conversation
This pull request does not have a backport label. Could you fix it @v1v? 🙏
NOTE: |
📚 Go benchmark reportDiff with the
report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat |
Is it cool if I backport this change to 8.7 as well? I'm seeing the same problem in that branch. |
@Mergifyio backport 8.7 |
✅ Backports have been created
|
(cherry picked from commit d362412)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit d362412)
(cherry picked from commit d362412)
Motivation/summary
lint
check is mandatory regardless of the changes, soci-docs.yml
is workaround to skip checks when the CI does. not run for docs changes.Otherwise, it might mislead contributors since the lint check will not allow merging docs only PRs.
cc @bmorelli25