Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog: add fleet ingest pipeline breaking change #12556

Merged
merged 5 commits into from
Feb 5, 2024

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Feb 2, 2024

Motivation/summary

See elastic/kibana#175254

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Part of #12498

@carsonip carsonip requested a review from a team as a code owner February 2, 2024 15:50
@carsonip carsonip requested a review from simitt February 2, 2024 15:50
Copy link
Contributor

mergify bot commented Feb 2, 2024

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Feb 2, 2024
@@ -13,6 +13,7 @@ https://github.com/elastic/apm-server/compare/8.11\...8.12[View commits]
==== Breaking Changes
- The unsupported apm_data_stream_migration ingest pipeline has been removed {pull}12102[12102].
- "publish_ready" is always false in the "GET /" response until events are received by apm-server {pull}12150[12150]
- (Known issue) `traces-apm@custom` ingest pipeline is now applied to data streams `traces-apm.sampled-*` and `traces-apm.rum.*` and applied twice for `traces-apm-*`. See Fleet changelog for details.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it clearly convey that it is a bug? Feel free to modify the wording.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about something like: "A bug has been introduced, so that traces-apm@custom ingest pipeline is now additionally applied to data streams traces-apm.sampled-* and traces-apm.rum.* and applied twice for traces-apm-*. See more details and information around a fix in the Known issue section"

And then add it to the Known issue section, and once 8.12.1 is released, we update the Known issue section with a note about the fix.

Copy link
Member Author

@carsonip carsonip Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Known issues lives in https://github.com/elastic/observability-docs/blob/main/docs/en/observability/apm/known-issues.asciidoc and will need to be updated separately.

@carsonip carsonip added backport-8.12 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Feb 2, 2024
@carsonip
Copy link
Member Author

carsonip commented Feb 2, 2024

run docs-build

@carsonip carsonip closed this Feb 2, 2024
@carsonip carsonip reopened this Feb 2, 2024
@carsonip carsonip enabled auto-merge (squash) February 5, 2024 11:00
@carsonip carsonip merged commit 6ed334a into elastic:main Feb 5, 2024
8 of 9 checks passed
mergify bot pushed a commit that referenced this pull request Feb 5, 2024
* changelog: add fleet ingest pipeline breaking change

See elastic/kibana#175254

Part of #12498

(cherry picked from commit 6ed334a)

# Conflicts:
#	changelogs/8.12.asciidoc
mergify bot added a commit that referenced this pull request Feb 5, 2024
…12556) (#12567)

* changelog: add fleet ingest pipeline breaking change (#12556)

* changelog: add fleet ingest pipeline breaking change

See elastic/kibana#175254

Part of #12498

(cherry picked from commit 6ed334a)

# Conflicts:
#	changelogs/8.12.asciidoc

* Fix conflict

---------

Co-authored-by: Carson Ip <carsonip@users.noreply.github.com>
Co-authored-by: Carson Ip <carson.ip@elastic.co>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.12 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants